rob
/
ramble
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Fix Qt cleanup warning on dialog close 

Add closeEvent that waits for thread pool workers to finish
before closing, preventing "shared QObject deleted directly" warning.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
This commit is contained in:
rob 2025-12-30 04:00:38 -04:00
parent 493a499888
commit 0041bc0fae
1 changed files with 5 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
src/ramble/dialog.py
View File

@ -428,6 +428,11 @@ class RambleDialog(QDialog):
self.result = RambleResult(summary=summary, fields=out_fields) self.result = RambleResult(summary=summary, fields=out_fields)
self.accept() self.accept()
def closeEvent(self, event):
"""Wait for background workers to finish before closing."""
self.thread_pool.waitForDone(1000) # Wait up to 1 second
super().closeEvent(event)
def open_ramble_dialog( def open_ramble_dialog(
*, *,