3 Commits

Author	SHA1	Message	Date
rob	ba7b6e79ff	Address second round of Codex review feedback on formations plan ... Fixes: 1. Class signature consistency - reference __init__ from 1.1, don't redefine 2. Dynamic chart ID - use this.data.chart1_id instead of hardcoded 'chart1' 3. Comms wiring - use this.comms.on() pattern like signals.js 4. RAF loop guards - add pause conditions, destroy() teardown hook 5. Drag null guards - validate chartCoords before mutating formation data 6. Test organization - split MVP tests from Phase C target tests Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>	2026-03-10 16:03:33 -03:00
rob	a46d2006f3	Update formations plan for Lightweight Charts v5 compatibility ... Addresses Codex review feedback: - Use series-based coordinate conversion (series.priceToCoordinate) - Add infinite line extension math (_getInfiniteLineEndpoints) - Fix message pattern: use sendToApp() not emit('message') - Remove wall clock fallback in get_current_candle_time() - Clarify architecture: socket handlers in BrighterTrades, not app.py - Clarify UX: shape appears at center, drag to adjust (no click-to-place) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>	2026-03-10 15:57:38 -03:00
rob	6a7a1c2b45	Fix indicator update callbacks and card display after refactor ... - Bind indicators.update callback to correct this context in general.js - Update updateDisplay to fall back to card elements when old chart elements don't exist - Add _formatDisplayValue helper for consistent value formatting - Remove verbose debug console.log statements - Add FORMATIONS_PLAN.md documenting SVG overlay approach for chart formations Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>	2026-03-10 15:01:55 -03:00