Fix test_BrighterTrades.py socketio mock issue

- Added proper mocking for all BrighterTrades dependencies (DataCache,
  ExchangeInterface, Users, Strategies, Candles, Indicators, Trades)
- Pass mock socketio instance to BrighterTrades constructor
- Fixed patch paths to use correct module path (src.BrighterTrades.*)
- All 5 tests now pass

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
This commit is contained in:
rob 2026-03-01 17:31:20 -04:00
parent 639043b261
commit da9d1fc5ee
1 changed files with 127 additions and 43 deletions

View File

@ -1,69 +1,153 @@
import unittest import unittest
from unittest.mock import patch, MagicMock from unittest.mock import patch, MagicMock
from src.BrighterTrades import BrighterTrades # Ensure you have the correct import path
class TestBrighterTrades(unittest.TestCase): class TestBrighterTrades(unittest.TestCase):
def setUp(self): def setUp(self):
self.brighter_trades = BrighterTrades() """Set up test fixtures with mocked dependencies."""
# Create a mock socketio instance
self.mock_socketio = MagicMock()
@patch('brighter_trades.Configuration') # Patch the dependencies before importing BrighterTrades
def test_create_new_user(self, MockConfiguration): self.patches = []
mock_config = MockConfiguration.return_value
mock_config.users.create_new_user.return_value = True # Patch DataCache
mock_config.users.log_in_user.return_value = True self.data_cache_patcher = patch('src.BrighterTrades.DataCache')
self.mock_data_cache_class = self.data_cache_patcher.start()
self.mock_data_cache = MagicMock()
self.mock_data_cache_class.return_value = self.mock_data_cache
self.patches.append(self.data_cache_patcher)
# Patch ExchangeInterface
self.exchange_interface_patcher = patch('src.BrighterTrades.ExchangeInterface')
self.mock_exchange_interface_class = self.exchange_interface_patcher.start()
self.mock_exchanges = MagicMock()
self.mock_exchange_interface_class.return_value = self.mock_exchanges
self.patches.append(self.exchange_interface_patcher)
# Patch Users
self.users_patcher = patch('src.BrighterTrades.Users')
self.mock_users_class = self.users_patcher.start()
self.mock_users = MagicMock()
self.mock_users_class.return_value = self.mock_users
self.patches.append(self.users_patcher)
# Patch Strategies
self.strategies_patcher = patch('src.BrighterTrades.Strategies')
self.mock_strategies_class = self.strategies_patcher.start()
self.mock_strategies = MagicMock()
self.mock_strategies_class.return_value = self.mock_strategies
self.patches.append(self.strategies_patcher)
# Patch Candles
self.candles_patcher = patch('src.BrighterTrades.Candles')
self.mock_candles_class = self.candles_patcher.start()
self.mock_candles = MagicMock()
self.mock_candles_class.return_value = self.mock_candles
self.patches.append(self.candles_patcher)
# Patch Indicators
self.indicators_patcher = patch('src.BrighterTrades.Indicators')
self.mock_indicators_class = self.indicators_patcher.start()
self.mock_indicators = MagicMock()
self.mock_indicators_class.return_value = self.mock_indicators
self.patches.append(self.indicators_patcher)
# Patch Trades
self.trades_patcher = patch('src.BrighterTrades.Trades')
self.mock_trades_class = self.trades_patcher.start()
self.mock_trades = MagicMock()
self.mock_trades_class.return_value = self.mock_trades
self.patches.append(self.trades_patcher)
# Now import and create BrighterTrades with mocked dependencies
from src.BrighterTrades import BrighterTrades
self.brighter_trades = BrighterTrades(self.mock_socketio)
# Assign mocks to the instance for easier access in tests
self.brighter_trades.users = self.mock_users
self.brighter_trades.candles = self.mock_candles
self.brighter_trades.exchanges = self.mock_exchanges
self.brighter_trades.strategies = self.mock_strategies
def tearDown(self):
"""Stop all patches."""
for patcher in self.patches:
patcher.stop()
def test_create_new_user(self):
"""Test creating a new user."""
self.mock_users.create_new_user.return_value = True
self.mock_users.log_in_user.return_value = True
result = self.brighter_trades.create_new_user('test@example.com', 'testuser', 'password') result = self.brighter_trades.create_new_user('test@example.com', 'testuser', 'password')
self.assertTrue(result)
mock_config.users.create_new_user.assert_called_with(email='test@example.com', username='testuser',
password='password')
mock_config.users.log_in_user.assert_called_with(username='testuser', password='password')
@patch('brighter_trades.Configuration') self.assertTrue(result)
def test_log_user_in_out_login(self, MockConfiguration): self.mock_users.create_new_user.assert_called_with(
mock_config = MockConfiguration.return_value email='test@example.com',
mock_config.users.log_in_user.return_value = True username='testuser',
password='password'
)
self.mock_users.log_in_user.assert_called_with(
username='testuser',
password='password'
)
def test_log_user_in_out_login(self):
"""Test user login."""
self.mock_users.log_in_user.return_value = True
result = self.brighter_trades.log_user_in_out('testuser', 'login', 'password') result = self.brighter_trades.log_user_in_out('testuser', 'login', 'password')
self.assertTrue(result)
mock_config.users.log_in_user.assert_called_with(username='testuser', password='password')
@patch('brighter_trades.Configuration') self.assertTrue(result)
def test_log_user_in_out_logout(self, MockConfiguration): self.mock_users.log_in_user.assert_called_with(
mock_config = MockConfiguration.return_value username='testuser',
mock_config.users.log_out_user.return_value = True password='password'
)
def test_log_user_in_out_logout(self):
"""Test user logout."""
self.mock_users.log_out_user.return_value = True
result = self.brighter_trades.log_user_in_out('testuser', 'logout') result = self.brighter_trades.log_user_in_out('testuser', 'logout')
self.assertTrue(result)
mock_config.users.log_out_user.assert_called_with(username='testuser')
@patch('brighter_trades.Configuration') self.assertTrue(result)
def test_get_user_info(self, MockConfiguration): self.mock_users.log_out_user.assert_called_with(username='testuser')
mock_config = MockConfiguration.return_value
mock_config.users.get_chart_view.return_value = {'timeframe': '1d', 'exchange': 'binance', 'market': 'BTC/USDT'} def test_get_user_info_chart_view(self):
"""Test getting user chart view info."""
expected_chart_view = {'timeframe': '1d', 'exchange': 'binance', 'market': 'BTC/USDT'}
self.mock_users.get_chart_view.return_value = expected_chart_view
result = self.brighter_trades.get_user_info('testuser', 'Chart View') result = self.brighter_trades.get_user_info('testuser', 'Chart View')
self.assertEqual(result, {'timeframe': '1d', 'exchange': 'binance', 'market': 'BTC/USDT'})
mock_config.users.get_chart_view.assert_called_with(user_name='testuser')
@patch('brighter_trades.Candles') self.assertEqual(result, expected_chart_view)
@patch('brighter_trades.Configuration') self.mock_users.get_chart_view.assert_called_with(user_name='testuser')
def test_get_market_info(self, MockConfiguration, MockCandles):
mock_candles = MockCandles.return_value def test_get_market_info_candle_history(self):
mock_candles.get_candle_history.return_value = [ """Test getting candle history."""
{'open': 1, 'high': 2, 'low': 0.5, 'close': 1.5, 'volume': 1000}] expected_candles = [
{'open': 1, 'high': 2, 'low': 0.5, 'close': 1.5, 'volume': 1000}
]
self.mock_candles.get_candle_history.return_value = expected_candles
chart_view = {'market': 'BTC/USDT', 'timeframe': '1d', 'exchange': 'binance'} chart_view = {'market': 'BTC/USDT', 'timeframe': '1d', 'exchange': 'binance'}
result = self.brighter_trades.get_market_info('Candle History', chart_view=chart_view, num_records=10, result = self.brighter_trades.get_market_info(
user_name='testuser') 'Candle History',
chart_view=chart_view,
self.assertEqual(result, [{'open': 1, 'high': 2, 'low': 0.5, 'close': 1.5, 'volume': 1000}]) num_records=10,
mock_candles.get_candle_history.assert_called_with(num_records=10, symbol='BTC/USDT', interval='1d', user_name='testuser'
exchange_name='binance', user_name='testuser') )
# Add more tests for other methods
self.assertEqual(result, expected_candles)
self.mock_candles.get_candle_history.assert_called_with(
num_records=10,
symbol='BTC/USDT',
interval='1d',
exchange_name='binance',
user_name='testuser'
)
if __name__ == '__main__': if __name__ == '__main__':
unittest.main() unittest.main()